Convert inline callbacks to async/await #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 75fa590.
Signed-off-by: H.Shay <shaysquared@gmail.com>
clokep
reviewed
Jun 22, 2021
clokep
suggested changes
Jun 24, 2021
|
Hmm I'm not entirely sure why the github actions run-matrix-is-tests (3.x) is failing-the buildkite tests passed and the tests are passing locally using both python 3.8 and 3.6. Looking at the details it seems to be some sort of connection error, I'm not sure the problem is in the code I'm pushing... |
|
Maybe sydent failed to start for some reason? I re-ran the jobs we'll see what happens. |
|
Looks like that worked! Thanks! |
clokep
approved these changes
Jun 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR converts some files in sydent to use async/await. I removed the references to the return type
Generatorin the affected functions but didn't add the new return types, I figured that should go in a seprate PR to ease review.